Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | Change printing of Warning stuck buffer_pool buffer from console.warn to console.error #8580

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Dec 5, 2024

Explain the changes

  1. Change printing of Warning stuck buffer_pool buffer from console.warn to console.error.

Issues:

  1. Related to issue Error: Warning stuck buffer_pool buffer with IO workload  #8521 when the buffer gets timeout (after 2 minutes by current configuration) it prints an error in logs, although the operation is not failing, and all the names are related to warning: warning_timer, Warning stuck buffer_pool buffer, this.warning_timeout, therefore changing it in the logs to WARN instead of ERROR.

Testing Instructions:

  1. none (if you want to reproduce it with code changes please see comment).
  • Doc added/updated
  • Tests added

…m `console.warn` to `console.error`

Signed-off-by: shirady <[email protected]>
@shirady shirady self-assigned this Dec 5, 2024
@shirady shirady merged commit 4847584 into noobaa:master Dec 5, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-buffer-pool-printings branch December 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants